[ffi] Set default parameter name in using callback#2253
Closed
dickermoshe wants to merge 1 commit intodart-lang:mainfrom
Closed
[ffi] Set default parameter name in using callback#2253dickermoshe wants to merge 1 commit intodart-lang:mainfrom
dickermoshe wants to merge 1 commit intodart-lang:mainfrom
Conversation
PR HealthBreaking changes ✔️
Changelog Entry ❗
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with
API leaks
|
| Package | Leaked API symbols |
|---|---|
| ffi | MallocAllocator CallocAllocator |
This check can be disabled by tagging the PR with skip-leaking-check.
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
| Files |
|---|
| no missing headers |
All source files should start with a license header.
Unrelated files missing license headers
| Files |
|---|
| pkgs/jni/lib/src/third_party/generated_bindings.dart |
| pkgs/objective_c/lib/src/ns_input_stream.dart |
Collaborator
|
If you want a release of the package, please also bump the version and add an entry to the changelog. |
Contributor
|
This was superseded by #2767. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an extremely minor change. Providing a argument name makes auto complete better.
Before:
Recording.2025-04-28.133050.mp4
After:
Recording.2025-04-28.132959.mp4
Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.